tracer: load initial maps from /proc/<pid>/maps
#655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this struct tracks threads within a single process; the old name conflated this with its use in an array in `struct memory_maps` to track multiple processes
oinoom
reviewed
Jan 13, 2026
| None => None, | ||
| Some(overlap) => Some(( | ||
| Self::from_bounds(self.start, overlap.start), | ||
| Self::from_bounds(self.end(), overlap.end()), |
Contributor
There was a problem hiding this comment.
won't this always return None, if self.end() >= overlap.end() (given the ordering of the args), and is that a problem?
oinoom
reviewed
Jan 13, 2026
| struct memory_map *load_initial_memory_map(pid_t pid) { | ||
| char *filename = NULL; | ||
| asprintf(&filename, "/proc/%d/maps", pid); | ||
| FILE *maps_file = fopen(filename, "r"); |
Contributor
|
Maybe not directly related to this PR, but I was looking through the track memory map given your hang issues, and noted that I didn't see handling in the syscall-exit path for WAIT_GROUP_STOP, WAIT_SIGSEGV, WAIT_SIGNALED, WAIT_CONT, and WAIT_PTRACE_FORK. Hopefully this helps. I wonder about the last one and if that's the one that's causing the hangs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315. That said, this is atop #595 which causes problems as I haven't finished debugging the tracer's hangs.